From 68e9e96953f7aad1bb3b2a1c15c26bbd94897346 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 21 Apr 2017 12:10:51 +0200 Subject: [PATCH] correct rcu_unlock_domain() Match rcu_lock_domain(), and remove the slightly misleading comment: This isn't just the companion to rcu_lock_domain_by_id() (and that latter function indeed also keeps the domain locked, not the domain list). No functional change, as rcu_read_{,un}lock() ignore their arguments anyway. Reported-by: Jann Horn Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Release-acked-by: Julien Grall --- xen/include/xen/sched.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 325733a4b8..1127ca99bd 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -581,11 +581,10 @@ int rcu_lock_remote_domain_by_id(domid_t dom, struct domain **d); */ int rcu_lock_live_remote_domain_by_id(domid_t dom, struct domain **d); -/* Finish a RCU critical region started by rcu_lock_domain_by_id(). */ static inline void rcu_unlock_domain(struct domain *d) { if ( d != current->domain ) - rcu_read_unlock(&domlist_read_lock); + rcu_read_unlock(d); } static inline struct domain *rcu_lock_domain(struct domain *d) -- 2.30.2